Stop the whole fleet stampeding one advisory lock at boot - #142
Merged
Conversation
All 23 DB-dependent containers start the instant Postgres reports healthy, and each one took a fleet-wide advisory lock to run the idempotent schema upgrades. On any volume created since those indexes landed in init_db.sql the upgrades are a no-op, but every container still queued for the lock, and whoever lost the queue blew postgres_pool_timeout and logged a PoolTimeout traceback on an otherwise healthy startup. Add a pre-flight catalog check outside the lock, so the already-applied case costs one indexed read and no serialization, and retry the upgrade with the same backoff the query paths use instead of burning a single 5s attempt when the DB blips during those first seconds. Also raise max_connections 200 -> 300. Both compose.yml and config.py document that the sum of per-container pool maxima must stay under it, but 22 workers at 10 plus the server at 30 is 250, so the invariant was already violated. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PQeAtdPFUgZ1BTB3UB6oXc
Codecov Report❌ Patch coverage is
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All 23 DB-dependent containers start the instant Postgres reports healthy, and each one took a fleet-wide advisory lock to run the idempotent schema upgrades. On any volume created since those indexes landed in init_db.sql the upgrades are a no-op, but every container still queued for the lock, and whoever lost the queue blew postgres_pool_timeout and logged a PoolTimeout traceback on an otherwise healthy startup.
Add a pre-flight catalog check outside the lock, so the already-applied case costs one indexed read and no serialization, and retry the upgrade with the same backoff the query paths use instead of burning a single 5s attempt when the DB blips during those first seconds.
Also raise max_connections 200 -> 300. Both compose.yml and config.py document that the sum of per-container pool maxima must stay under it, but 22 workers at 10 plus the server at 30 is 250, so the invariant was already violated.
Claude-Session: https://claude.ai/code/session_01PQeAtdPFUgZ1BTB3UB6oXc